feat(integrations): add option to filter by integration type #78656
Conversation
github-actions
bot
added
the
Scope: Backend
| ) | ||
| assert response.data == [] | ||
|
|
||
| def test_integration_type(self): |
There was a problem hiding this comment.
nit: maybe add a test for what happens when u pass both providerKey and integrationType
also maybe throw docs in ur backlog
| DEPLOYMENT = "deployment" | ||
|
|
||
|
|
||
| # Integration Types |
There was a problem hiding this comment.
hmm i would love to do something so that when you register the integrations here
sentry/src/sentry/runner/initializer.py
Lines 59 to 76 in c92f4b8
you also register the integration type... cc @RyanSkonnord if you have thoughts
| IntegrationProviderSlug.DISCORD, | ||
| IntegrationProviderSlug.MSTeams, | ||
| ], | ||
| PROJECT_MANAGEMENT: [ |
There was a problem hiding this comment.
Many (or all) of source code management integrations are also project management ones. At least Github and Azure are. @cathteng can confirm which ones for sure.
There was a problem hiding this comment.
are we grouping integrations by the main focus or by a particular feature? i would say the ticketing aspect of SCMs is a feature
There was a problem hiding this comment.
@sentaur-athena @cathteng I just grouped them based on our integration feature list
There was a problem hiding this comment.
@cathteng we can come back and update this list since it's not really used anywhere in code other than messaging. My thought is for example if we want to build onboarding and tell people we have these ticket management integrations we still want to return github in that list.
add query param to filter by
integrationType:messagingproject_managementsource_code_managementon_call_scheduling